Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primitives attributes が有ったり無かったりする場合に対応(例えばNORMAL) #644

Merged
merged 2 commits into from
Jan 6, 2021
Merged

primitives attributes が有ったり無かったりする場合に対応(例えばNORMAL) #644

merged 2 commits into from
Jan 6, 2021

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jan 4, 2021

hiroj
hiroj reviewed Jan 4, 2021
View reviewed changes
Assets/UniGLTF/Runtime/UniGLTF/IO/MeshImporter.cs Outdated
{
throw new NotImplementedException();
throw new Exception("ありえない");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

もうちょっと詳しく書いたほうが良さそう、UniGLTFの部分なのでエラーメッセージは英語にしてあげたほうがいいかも

@ousttrue
Copy link
Contributor Author

ousttrue commented Jan 4, 2021

update English comment

@ousttrue ousttrue merged commit 6d47270 into vrm-c:master Jan 6, 2021
@ousttrue ousttrue deleted the fix/mesh_import branch April 2, 2021 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroj hiroj hiroj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ousttrue @hiroj