Feature10/refactor materialimporter #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MaterialImporter を interface から delegate に格下げ * UniUnlit の導入により不要になった ShaderStore を削除
Santarh
approved these changes
Feb 10, 2021
| namespace UniGLTF | ||
| { | ||
| public delegate TextureItem GetTextureItemFunc(int i); | ||
| public delegate Shader GetShaderFunc(); |
There was a problem hiding this comment.
GetShaderFunc IShaderStore が思ったより消えて不要になってました。
次で消しておきます。
| public delegate MaterialItemBase MaterialImporter(int i, glTFMaterial x, bool hasVertexColor); | ||
|
|
||
|
|
||
| public class MaterialFactory |
There was a problem hiding this comment.
MaterialFactory 自体が中間生成物の UnityEngine.Object を生成する可能性があるので
コレ自体が IDisposable である必要はありそう
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#732 の準備