vrm1 の Export インタフェースを整理 #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Santarh
approved these changes
Apr 12, 2021
| @@ -200,7 +200,7 @@ public void Export(GameObject root, Model model, RuntimeVrmConverter converter, | |||
|
|
|||
| (UniGLTF.Extensions.VRMC_vrm.VRMC_vrm vrm, UniGLTF.Extensions.VRMC_springBone.VRMC_springBone springBone, int? thumbnailIndex) ExportVrm(GameObject root, Model model, RuntimeVrmConverter converter, VRM10MetaObject meta) | |||
| { | |||
| var vrmController = root.GetComponent<VRM10Controller>(); | |||
| var vrmController = root?.GetComponent<VRM10Controller>(); | |||
| // 右手系に変換 | ||
| model.ConvertCoordinate(VrmLib.Coordinates.Vrm1); | ||
| var exportedBytes = model.ToGlb(TextureExporter.GetTextureBytesWithMime); | ||
| var exportedBytes = Vrm10Exporter.Export(go); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VrmLib.Model から Vrm 情報を除去したので、Model 単体から Vrm をエクスポートすることができなくなった。
Model.ToGlb を廃止して、Model の元になる GameObject を引数に取る、Vrm10Exporter.Export を実装した。