Add nperiods property to Driver
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will just add the possibility to configure the number of periods used by the underlying soundcard. This can be especially helpfull when tailoring performance on jittery systems.
|
Hi there! Looks great, can you just add tests? I want to keep coverage at 100%. |
hmm. jack2 dummy driver - used in the tests - doesn't allow you to change |
|
OK, got it. I will see what can be done once I’ll be in front of computer 😃 |
This reverts commit 5702e60.
|
I don't want to add |
vrslev
added a commit
that referenced
this pull request
Jan 31, 2024
|
Just released v0.2.0—it includes this PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will just add the possibility to configure the number of periods used by the underlying soundcard. This can be especially helpfull when tailoring performance on jittery systems.