Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(v1): set terser to remove generated comments #20

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

jstcl
Copy link
Collaborator

@jstcl jstcl commented Sep 23, 2021

Set terser plugin to remove generated comments at build (production) file by setting production output comments to false. Also, I'm formatting this file with prettier for better and read-able code.

@vercel
Copy link

vercel bot commented Sep 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gifaldyazkaa/aqua-fanpage/78qiiJUWGwDz7vM4BNHvqngdrJSr
✅ Preview: https://aqua-fanpage-git-fork-shiraayuki-dev-gifaldyazkaa.vercel.app

@azukashi
Copy link
Member

Poggerific, You just opened your first pull request and contributed to this repository!

Nice work! Thanks for contributing @shiraayuki ! And thanks for formatting the code. 👍🏻

Copy link
Member

@azukashi azukashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this ✅

@azukashi azukashi merged commit 7118d08 into vrtpro:master Sep 23, 2021
@vrtpro vrtpro locked as resolved and limited conversation to collaborators Sep 23, 2021
@azukashi azukashi added enhancement New feature or request good first issue Good for newcomers labels Sep 23, 2021
@vrtpro vrtpro deleted a comment from jstcl Sep 23, 2021
@vrtpro vrtpro deleted a comment from jstcl Sep 23, 2021
@vrtpro vrtpro deleted a comment from jstcl Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants