Merge pull request #1059 from jamierobertson1/master

Update UpdateOperations::Remove to prevent Visual Studio crash in debug mode
vsg-dev · Jan 1, 2024 · 0257fdd · 0257fdd
2 parents 486afff + 801a310
commit 0257fdd
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/src/vsg/app/UpdateOperations.cpp b/src/vsg/app/UpdateOperations.cpp
@@ -35,14 +35,8 @@ void UpdateOperations::add(ref_ptr<Operation> op, RunBehavior runBehavior)
 void UpdateOperations::remove(ref_ptr<Operation> op)
 {
     std::scoped_lock<std::mutex> lock(_updateOperationMutex);
-    for (auto itr = _updateOperationsOneTime.begin(); itr != _updateOperationsOneTime.end(); ++itr)
-    {
-        if (*itr == op) itr = _updateOperationsOneTime.erase(itr);
-    }
-    for (auto itr = _updateOperationsAllFrames.begin(); itr != _updateOperationsAllFrames.end(); ++itr)
-    {
-        if (*itr == op) itr = _updateOperationsAllFrames.erase(itr);
-    }
+    _updateOperationsOneTime.remove(op);
+    _updateOperationsAllFrames.remove(op);
 }
 
 void UpdateOperations::clear()