-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builder::decorateAndCompileIfRequired returns wrong node #1122
Comments
lufriem
added a commit
to lufriem/VulkanSceneGraph
that referenced
this issue
Mar 12, 2024
The fix looks appropriate, could you generate a PR for this fix, thanks. I'm curious what is the type of GeomInfo.positions in your usage case? |
9 tasks
Sorry I thought I did, still trying to figure out git(hub). I came across this while reading through the code, I don't actually have any test code/data to force the code to run this particular execution branch. |
robertosfield
added a commit
that referenced
this issue
Mar 13, 2024
Corrected function return value. Fixes #1122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think that's more of a latent bug, but it looks to me like Builder::decorateAndCompileIfRequired should, in case it's directed to create a cull node but cannot compute the bounds, return the 'subgraph' variable rather than its 'node' argument
So, basically, change line 252 from 'return node;' to 'return subgraph;'
The text was updated successfully, but these errors were encountered: