Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder::decorateAndCompileIfRequired returns wrong node #1122

Closed
lufriem opened this issue Mar 12, 2024 · 2 comments · Fixed by #1123
Closed

Builder::decorateAndCompileIfRequired returns wrong node #1122

lufriem opened this issue Mar 12, 2024 · 2 comments · Fixed by #1123

Comments

@lufriem
Copy link
Contributor

lufriem commented Mar 12, 2024

I think that's more of a latent bug, but it looks to me like Builder::decorateAndCompileIfRequired should, in case it's directed to create a cull node but cannot compute the bounds, return the 'subgraph' variable rather than its 'node' argument

So, basically, change line 252 from 'return node;' to 'return subgraph;'

lufriem added a commit to lufriem/VulkanSceneGraph that referenced this issue Mar 12, 2024
@robertosfield
Copy link
Collaborator

The fix looks appropriate, could you generate a PR for this fix, thanks.

I'm curious what is the type of GeomInfo.positions in your usage case?

@lufriem
Copy link
Contributor Author

lufriem commented Mar 13, 2024

Sorry I thought I did, still trying to figure out git(hub). I came across this while reading through the code, I don't actually have any test code/data to force the code to run this particular execution branch.

robertosfield added a commit that referenced this issue Mar 13, 2024
Corrected function return value. Fixes #1122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants