FIX: handle change aspect change when render area is not full window. #1066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the camera viewport is not the full window, the aspect ratio of the perspective projection matrix needs to be adjusted in the same way as the EllipsoidPerspective case.
Type of change
This is a behavior-changing fix since the aspect ratio was incorrectly calculated when the viewport extent is not exactly the same as the window extent.
How Has This Been Tested?
I have tested within my own framework built on top of VSG. I could include a minimal example, but I feel it is unneccessary because VSG already has the correct code in EllipsoidPerspective. This PR aligns the behavior of
Perspective::changeExtent()
andEllipsoidPerspective::changeExtent()
.Checklist:
I have considered the following items, but believe no action needs to be taken