Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About getAvailability in Descriptor Pool #925

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

echolumj
Copy link
Contributor

@echolumj echolumj commented Aug 23, 2023

Description

DescriptorPool.cpp line 147: change "itr != descriptorPoolSizes.end() " to "itr == descriptorPoolSizes.end()"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robertosfield
Copy link
Collaborator

If you think there is a bug could you explain how to reproduce it?

@robertosfield
Copy link
Collaborator

@echolumj I can't begin to review this PR until I have clear description of the problem that it's intended to address, it could well be that you have just misread the intent of the code and this PR might be introducing a bug rather than fixing one.

@robertosfield
Copy link
Collaborator

I have been reviewing the code and believe your PR is correct, but incomplete as we shouldn't be adding entries when the availableCount is zero. I'll merge this PR and the add the required check, thought this check for zero perhaps should be elsewhere with the entry in the map removed completely.

@robertosfield robertosfield merged commit 84eb95a into vsg-dev:master Aug 23, 2023
8 checks passed
@robertosfield
Copy link
Collaborator

I have added an extra check and inline comments to better explain what is going on:

82fa883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants