Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add deletionProtection for managed crossplane resources #244

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Add deletionProtection for managed crossplane resources #244

merged 1 commit into from
Oct 30, 2024

Conversation

TheBigLee
Copy link
Member

@TheBigLee TheBigLee commented Oct 16, 2024 •
edited
Loading

Summary

  • This PR adds deletion protection for various managed crossplane resources

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@TheBigLee TheBigLee added enhancement New feature or request minor labels Oct 16, 2024
@vshnbot vshnbot mentioned this pull request Oct 16, 2024
Open
3 tasks
@TheBigLee TheBigLee force-pushed the spks/deletion_protection branch 10 times, most recently from 4866512 to 0d2d255 Compare October 17, 2024 09:58
@TheBigLee TheBigLee changed the title Add deletionProtection for releases Add deletionProtection for releases and objects Oct 17, 2024
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team, Kidswiss, wejdross and zugao October 17, 2024 09:59
@TheBigLee TheBigLee force-pushed the spks/deletion_protection branch 8 times, most recently from 2d076ef to 6be9319 Compare October 17, 2024 15:29
@TheBigLee TheBigLee force-pushed the spks/deletion_protection branch 2 times, most recently from 703ca31 to 996760e Compare October 17, 2024 15:49
@TheBigLee TheBigLee requested review from a team, Kidswiss, wejdross and zugao and removed request for a team October 17, 2024 15:51
@TheBigLee TheBigLee force-pushed the spks/deletion_protection branch from 996760e to 4551433 Compare October 17, 2024 15:51
@TheBigLee TheBigLee changed the title Add deletionProtection for releases and objects Add deletionProtection for managed crossplane resources Oct 17, 2024
Kidswiss
Kidswiss approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/comp-functions/functions/vshnmariadb/user_management.go Outdated Show resolved Hide resolved
@TheBigLee
Add deletionProtection for managed crossplane resources
e128ede 
Signed-off-by: Nicolas Bigler <nicolas.bigler@vshn.ch>
@TheBigLee TheBigLee force-pushed the spks/deletion_protection branch from 4551433 to e128ede Compare October 18, 2024 10:49
@TheBigLee TheBigLee requested a review from zugao October 18, 2024 10:50
zugao
zugao approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to test it in dev cluster before pushing to prod

@TheBigLee TheBigLee merged commit 12d2103 into master Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@Kidswiss Kidswiss Kidswiss approved these changes

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheBigLee @Kidswiss @zugao