Fix wrong pgbouncer toggle #282
Merged
+3
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Kidswiss
requested review from
a team,
TheBigLee,
wejdross and
zugao
and removed request for
a team
Kidswiss
force-pushed
the
fix/default_pgbouncer
branch
from
5f59224 to
511d7bc
Compare
TheBigLee
approved these changes
Dec 11, 2024
Unfortunately we inverted the boolean that enables/disables the pgbouncer. Currently if `service.disablePgBouncer: false` is set, it will result in `disableConnectionPooling: true` in the sgcluster. Which in fact disables the pgbouncer, while it should be enabled in that case. As both booleans are negative already, they should not be inverted!
wejdross
force-pushed
the
fix/default_pgbouncer
branch
from
0cf1185 to
c463aba
Compare
|
Ok, I tested it on LAB cluster and since this setting is managed by Stackgres itself, we won't be affected by restarts unless maintenance job is run. Current state: I'd say we're good to go with merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately we inverted the boolean that enables/disables the pgbouncer.
Currently if
service.disablePgBouncer: falseis set, it will result indisableConnectionPooling: truein the sgcluster. Which in fact disables the pgbouncer, while it should be enabled in that case.As both booleans are negative already, they should not be inverted!
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog