Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Make fact object updatable in database #29

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Make fact object updatable in database #29

merged 1 commit into from
Dec 1, 2022

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Dec 1, 2022

Summary

  • Make fact object updatable as it is already for products.

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog

Copy link

@glrf glrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I could nitpick a little and make a propose that we use INSERT .. ON CONFLICT UPDATE .. and simplify all this, but it's fine as is and the products already work the same way :)

@zugao
Copy link
Contributor Author

zugao commented Dec 1, 2022

I could nitpick a little and make a propose that we use INSERT .. ON CONFLICT UPDATE .. and simplify all this, but it's fine as is and the products already work the same way :)

We plan to do major refactoring of exoscale-metrics-collector and cloudscale-metrics-collector by merging them. I would add your valuable suggestions there and make sure they are implemented.

@zugao zugao merged commit 9e99e29 into master Dec 1, 2022
@zugao zugao deleted the facts-updatable branch December 1, 2022 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants