Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: end date not displaying in redirects list #454

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

caroolcanelas
Copy link
Contributor

What problem is this solving?

The redirects page was not showing up the end date of temporary redirects

How should this be manually tested?

Before:
Enter a redirect page on the CMS module and try to look for the end date on the UI
image

After:
Now you can see the end date on the redirects UI
image

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

Notes

Zendesk Ticket: #833375

How does this PR make you feel? 🔗

@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 16, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@iago1501 iago1501 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2023
Copy link
Contributor

@iago1501 iago1501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@caroolcanelas caroolcanelas merged commit c7503c1 into master Jun 21, 2023
@caroolcanelas caroolcanelas deleted the fix/redirects-endDate branch June 21, 2023 14:09
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 21, 2023

Your PR has been merged! App is being published. 🚀
Version 4.51.0 → 4.51.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.admin-pages@4.51.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants