-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add touch-action style property #117
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Add touch-action style property to the sliderLayoutContainer component to prevent unexpected scrolling on Y axis when moving finger horizontally
How to test it?
Before this fix, if you scroll the slider horizontally with your finger it may also scroll the page on Y axis when the touch move direction is not straight. Now if you initiate horizontal scrolling it will not scroll the page vertically
URL to test:
https://devalex--dunnesstorespreprod.myvtex.com
Screenshots or example usage:
Before:
https://github.com/user-attachments/assets/001445ff-78c1-4969-b0af-3863f104cf57
After:
https://github.com/user-attachments/assets/b1e991c5-7c7f-4330-80f6-fd7bd1b4e582