Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/disable b2b flag #522

Merged
merged 3 commits into from
May 13, 2021
Merged

Chore/disable b2b flag #522

merged 3 commits into from
May 13, 2021

Conversation

brunoabreu
Copy link
Contributor

What problem is this solving?

The "enables B2B behavior" flag is dangerous as it makes our GraphQL and navigation requests not cacheable. It was necessary because the user's token is required when fetching data from private sales channels. However some months ago we managed to create a new solution based on the segment cookie.

We are deprecating this flag now. The first step is to disable it.

How to test it?

Beta version installed here: https://brunoh--b2bstore.myvtex.com/admin/app/cms/store

Screenshots or example usage:

image

@brunoabreu brunoabreu requested a review from a team as a code owner May 11, 2021 15:25
@brunoabreu brunoabreu requested review from igorbrasileiro, victorhmp and RodrigoTadeuF and removed request for a team May 11, 2021 15:25
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented May 11, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented May 11, 2021

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@brunoabreu brunoabreu merged commit 86e4bb2 into master May 13, 2021
@brunoabreu brunoabreu deleted the chore/disable-b2b-flag branch May 13, 2021 20:16
@vtex-io-ci-cd
Copy link
Contributor

vtex-io-ci-cd bot commented May 13, 2021

Your PR has been merged! App is being published. 🚀
Version 2.116.0 → 2.117.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store@2.117.0

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants