Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WISHLIST-34] fix favorited & duplicate check #102

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

auroraaaashen
Copy link
Contributor

What problem is this solving?

bugfix for product page favorited check and fix the duplicate item added to the same list

How to test it?

  1. Go to any workspace that has this update linked
  2. Login with an account that has saved products on the wishlist.
  3. Save any item and go to the wishlist page.
  4. Enter to the product you just added and validate the heart icon (it should be a favorited heart)

If you don't see a favorited heart, please contact me.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 10, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 10, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@auroraaaashen auroraaaashen force-pushed the bugfix/WISHLIST-34_fix-favorited-check branch 3 times, most recently from f66daaa to 1881d35 Compare March 10, 2022 04:28
@auroraaaashen auroraaaashen requested a review from btalma March 14, 2022 16:04
@auroraaaashen auroraaaashen force-pushed the bugfix/WISHLIST-34_fix-favorited-check branch from 1881d35 to df143d6 Compare March 14, 2022 16:33
@sonarqubecloud
Copy link

[vtex-apps_wish-list-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[vtex-apps_wish-list-dotnet] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@auroraaaashen auroraaaashen merged commit d781b7b into master Mar 14, 2022
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 14, 2022

Your PR has been merged! App is being published. 🚀
Version 1.11.2 → 1.11.3

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.wish-list@1.11.3

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@auroraaaashen auroraaaashen deleted the bugfix/WISHLIST-34_fix-favorited-check branch August 2, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants