Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WISHLIST38] Set timeout to 60s #106

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Conversation

auroraaaashen
Copy link
Contributor

What problem is this solving?

For account Compracerta has a large amount of wishlist data, the download threw proxy timeout errors. This PR set the timeout to 60s and the ttl to 60s to avoid the proxy timeout.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 16, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Mar 16, 2022

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@sonarqubecloud
Copy link

[vtex-apps_wish-list-ts] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[vtex-apps_wish-list-dotnet] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

@albertm805 albertm805 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auroraaaashen auroraaaashen merged commit 8abed42 into master Mar 17, 2022
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 17, 2022

Your PR has been merged! App is being published. 🚀
Version 1.11.4 → 1.11.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.wish-list@1.11.5

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@auroraaaashen auroraaaashen deleted the bugfix/WISHLIST-38_time-out branch August 2, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants