[WISHLIST-43] fix localStore update

[auroraaaashen]

What does this PR do?

Fix the bug about updating removed wishlist items in localStore

How to test it?
https://aurora--compracerta.myvtex.com/

1. login into the workspace page
2. add an item to your wishlist and open two tabs of this product
3. unfavorited this item on one page, and go to another page and refresh
4. you should see the item is also unfavorited on the second page

[vtex-io-ci-cd]

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

• Patch (backwards-compatible bug fixes)

• Minor (backwards-compatible functionality)

• Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

• No thanks, I would rather do it manually 😞

[vtex-io-docs-bot]

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

• There's nothing new to document 🤔
• I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

• I just updated 🎉🎉

[sonarqubecloud]

[vtex-apps_wish-list-ts] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[sonarqubecloud]

[vtex-apps_wish-list-dotnet] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[arturmagalhaesjr]

Suggested change

	if (
	data?.checkList?.inList !== true &&
	productCheck[productId] === undefined &&
	wishListed.find(
	(item: any) => item.productId === productId && item.sku === sku
	) !== undefined
	) {
	wishListed = wishListed.filter(
	(item: any) => item.productId !== productId && item.sku !== sku
	)
	saveToLocalStorageItem(wishListed)
	setState({
	...state,
	isWishlistPage: false,
	})
	}
	wishListed = wishListed.filter(
	(item: any) => item.productId !== productId && item.sku !== sku
	)
	if (
	data?.checkList?.inList !== true &&
	productCheck[productId] === undefined &&
	wishListed.length > 0
	) {
	saveToLocalStorageItem(wishListed)
	setState({
	...state,
	isWishlistPage: false,
	})
	}

Take a look at this suggestion, first, you filter the array, and then you check if the length is greater than 0.

Probably my suggestion doesn't have a valid eslint check.

[auroraaaashen]

Thank you for the suggestion. But the wishListed could originally have more than one item in the list.
And we want to use the filter to remove the item only under the condition that we find the item in the wishListed and the inList in false(which read from the network).

[arturmagalhaesjr]

LGTM

[vtex-io-ci-cd]

Your PR has been merged! App is being published. 🚀
Version 1.12.1 → 1.12.2

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.wish-list@1.12.2

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖