Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDU-12704: Fix data attribute #1516

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

mariana-caetano
Copy link
Contributor

@mariana-caetano mariana-caetano commented Oct 28, 2024

Types of changes

  • New content (guides, endpoints, app documentation)
  • Improvement (make a documentation even better)
  • Fix (fix a documentation error)
  • Spelling and grammar accuracy (self-explanatory)

Fixes in this PR:

  • Doc typos.
  • Mention about other data attributes. In the first step, there's a mention of the data-fs-price-variant data attributes with the Listing value, but the data-fs-price-variant does not need to be mentioned in this step, and the Listing value is mentioned in the second step.

@mariana-caetano mariana-caetano self-assigned this Oct 28, 2024
Copy link
Contributor

Navigation Preview Link

No changes detected in the navigation.json file

Copy link
Contributor

Preview Links

Open this URL to set up the portal with this branch changes.

You can now access the edited pages with the following URLs:

@mariana-caetano mariana-caetano marked this pull request as ready for review October 28, 2024 19:23
@mariana-caetano mariana-caetano merged commit 039c101 into main Oct 28, 2024
6 checks passed
@mariana-caetano mariana-caetano deleted the EDU-12704-review-styling-component branch October 28, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants