Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update image js to help-center-content repo action #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardoaerobr
Copy link
Contributor

No description provided.

Copy link
Collaborator

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @ricardoaerobr!

Got this error when running locally:

image

I could give you some suggestions to fix this, but before going any further I think you should consider the following:

  • Currently (on main) this script is indeed not called by index.js, but it is run by a GitHub action each time a PR is opened in this repository.
  • Given that, it's not clear to me why it's necessary to make it run along with index.js. I think having it as a pull request action is enough and makes it easier to identify errors in image conversion. What are your thoughts on this? cc @PedroAntunesCosta

The key issue that needs to be fixed in the update-images script is image compression. The inability to compress large images seems to be the only error causing the action to fail on pull requests, so I would focus on solving that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants