Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #35: monster abilities and equipment sort order rework #203

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

hogwrassler
Copy link
Contributor

@hogwrassler hogwrassler commented Aug 14, 2022

This PR addresses #35

  • For monsters, sort Abilities & Equipment by attack pattern, then weapons before abilities, then alphabetical.
    *Sort inventory and spells alphabetically within groups.
  • Set ability default attack pattern to transparent (was white),
  • include transparent in attack pattern cycling

This is my first PR here and I am not experienced with javascript, so any suggestions for improvements are welcome!

order rework. sort by attack pattern, then weapons before abilities,
then alphabetical.  Sort inventory and spells alphabetically within groups.
Set ability default attack pattern to transparent, and allow to cycle
 back to transparent attack pattern.
@anthonyronda anthonyronda self-requested a review August 20, 2022 18:28
@anthonyronda
Copy link
Member

Sorry this took a while. Reviewing now!

@anthonyronda anthonyronda added this to the 1.6.4 milestone Sep 1, 2022
@anthonyronda
Copy link
Member

Tested, shown to be working in V10! Nice work and thank you!

Please see #59 and add your details
I'm maintaining both a list of contributors (via all-contributors bot) and a list of copyright authors (the AUTHORS file)

@anthonyronda anthonyronda merged commit 3b40987 into vttred:main Sep 7, 2022
@anthonyronda
Copy link
Member

@all-contributors please add @hogwrassler for code 🎉

@allcontributors
Copy link
Contributor

@anthonyronda

I've put up a pull request to add @hogwrassler! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants