Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: apply damage to original target was broken #394

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix: apply damage to original target was broken #394

merged 1 commit into from
Apr 11, 2023

Conversation

amir-arad
Copy link
Contributor

original target was not passed correctly to chat template

@amir-arad
fix: apply damage to original target was broken
06d4faa 
original target was not passed correctly to chat template
anthonyronda
anthonyronda approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also, this appears to fix 4 tests that previously failed in main (although I didn't check which because I tested main first, also I forgot to pull from origin/main so I'm not sure if it's up to date anyway)

@anthonyronda anthonyronda merged commit 36a5f37 into vttred:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonyronda anthonyronda anthonyronda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amir-arad @anthonyronda