Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule no-static-element-interactions #680

Merged
merged 10 commits into from
Jan 14, 2023
Merged

Add rule no-static-element-interactions #680

merged 10 commits into from
Jan 14, 2023

Conversation

ror-y
Copy link
Contributor

@ror-y ror-y commented Jan 12, 2023

Proposed Changes

Add an adaptation of the no-static-element-interactions found in https://github.com/jsx-eslint/eslint-plugin-jsx-a11y.

Demo

Screenshot 2023-01-12 at 12 09 44

Tests

Screenshot 2023-01-12 at 12 05 16

Disclaimer

This is my first contribution so feel free to scrutinise.

src/rules/interactive-supports-focus.ts Outdated Show resolved Hide resolved
src/utils/interactiveHandlers.ts Outdated Show resolved Hide resolved
src/utils/isInteractiveRole.ts Outdated Show resolved Hide resolved
src/utils/getInteractiveRoles.ts Outdated Show resolved Hide resolved
src/rules/no-static-element-interactions.ts Outdated Show resolved Hide resolved
@ror-y
Copy link
Contributor Author

ror-y commented Jan 13, 2023

Thanks @vhoyer – the PR has been updated following your review.

@ror-y ror-y requested a review from vhoyer January 13, 2023 14:46
@vhoyer
Copy link
Collaborator

vhoyer commented Jan 13, 2023

the CI has failed, can you fix it?

@ror-y
Copy link
Contributor Author

ror-y commented Jan 14, 2023

the CI has failed, can you fix it?

CI now passing (I had to run prettier) but yarn.lock has conflicts, and I'm not entirely sure why.

EDIT: I needed to update from upstream, it's all good now.

@kddnewton kddnewton merged commit 7d02a25 into vue-a11y:main Jan 14, 2023
@kddnewton
Copy link
Collaborator

Looks good, thanks for the contribution!

@vhoyer
Copy link
Collaborator

vhoyer commented Jan 14, 2023

Hey! thanks for the merge :D

@vhoyer
Copy link
Collaborator

vhoyer commented Jan 14, 2023

@ror-y thanks for the PR :D

@ror-y
Copy link
Contributor Author

ror-y commented Jan 15, 2023

@ror-y thanks for the PR :D

My pleasure 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants