fix: add typings for Empty component #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-desing-vue processing. Building with commit e2d0500 https://app.netlify.com/sites/ant-desing-vue/deploys/5dd40113175cec00087d9015 |
Svreber
force-pushed
the
add-typings-for-empty-component
branch
from
7c674b7
to
e2d0500
Compare
Codecov Report
@@ Coverage Diff @@
## master #1439 +/- ##
==========================================
+ Coverage 87.9% 87.92% +0.01%
==========================================
Files 156 156
Lines 5398 5398
Branches 1523 1523
==========================================
+ Hits 4745 4746 +1
Misses 583 583
+ Partials 70 69 -1
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a ...
What's the background?
The Empty component (added in 1.4.0) has no type def in the ant-design-vue project.
The Empty component had no typings definition and could not be imported independentely using the Typescript approach.
I didn't find any issue regarding this.
Changelog description (Optional if not new feature)
Added type definition for Empty component.
Self Check before Merge