Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue data.filter is not a function #1684

Closed
wants to merge 1 commit into from
Closed

fixed issue data.filter is not a function #1684

wants to merge 1 commit into from

Conversation

alirezavalizade
Copy link
Contributor

@alirezavalizade alirezavalizade commented Jan 2, 2020

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@netlify
Copy link

netlify bot commented Jan 2, 2020

Deploy preview for ant-desing-vue processing.

Building with commit 221d0ff

https://app.netlify.com/sites/ant-desing-vue/deploys/5e0de921a47155000833e25f

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1684 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
+ Coverage   88.01%   88.03%   +0.01%     
==========================================
  Files         157      157              
  Lines        5406     5406              
  Branches     1522     1522              
==========================================
+ Hits         4758     4759       +1     
+ Misses        579      578       -1     
  Partials       69       69
Impacted Files Coverage Δ
components/table/Table.jsx 86.22% <100%> (ø) ⬆️
components/calendar/Header.jsx 90.62% <0%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8574d1...221d0ff. Read the comment docs.

@tangjinzhou
Copy link
Member

can you give me an example ?

@alirezavalizade
Copy link
Contributor Author

Got a lot of error reports from Sentry, Checkout the prop data and it was fine, but don't know really what's happening. the line which I changed has a problem (the data is not Array)

@tangjinzhou
Copy link
Member

I closed it, I can not reproduce this.

@tangjinzhou tangjinzhou closed this Jul 1, 2020
@github-actions
Copy link

github-actions bot commented Jul 2, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants