Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: page-header组件设置backIcon为false,隐藏backIcon失败问题 #1987

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: page-header组件设置backIcon为false,隐藏backIcon失败问题 #1987

merged 1 commit into from
Mar 31, 2020

Conversation

mingtianyihou33
Copy link
Contributor

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

Changelog description (Optional if not new feature)

  1. English description
  2. 由于项目需要动态判断是否有返回图标,但使用backIcon属性为false,并没有像api上说的能隐藏图标,查看代码后发现是“||” 判断的问题,导致设置为false后显示了默认值

@tangjinzhou tangjinzhou merged commit c66177b into vueComponent:master Mar 31, 2020
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants