Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prop tab-size for card #3762

Merged
merged 3 commits into from
Mar 9, 2021
Merged

Conversation

Kaworus
Copy link

@Kaworus Kaworus commented Mar 8, 2021

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Set Card size with value 'small'.
  2. Tabs in Card should has an prop to set.
  3. Hard code tabs size in card #3741 (comment)

API Realization (Optional if not new feature)

image
image
image

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.
first time,am i right?

@zkwolf
Copy link
Member

zkwolf commented Mar 8, 2021

还是和ant design api保持一致比较好,参照这个ant-design/ant-design#22207 来个pr?

@Kaworus
Copy link
Author

Kaworus commented Mar 8, 2021

还是和ant design api保持一致比较好,参照这个ant-design/ant-design#22207 来个pr?

参考这个弄好了,第一次提PR不知道弄得对不对

@tangjinzhou tangjinzhou merged commit dced59c into vueComponent:master Mar 9, 2021
@@ -145,7 +147,7 @@ export default {
const hasActiveTabKey = activeTabKey !== undefined;
const tabsProps = {
props: {
size: 'large',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能remove啊,默认是large

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants