Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button, DatePicker, Layout d.ts #422

Merged
merged 2 commits into from
Jan 19, 2019

Conversation

Pythonfo
Copy link
Contributor

@Pythonfo Pythonfo commented Jan 18, 2019

ButtonGroup 应该是 Button 的静态属性。

RangePicker, MonthPicker, WeekPicker 也是 DatePicker 上的静态属性。

从组件的源码上看来,Layout上除了Sider子组件为静态属性外,还有Header, Content, Footer

然后在 class 中,propertyName: type 的意思是这个属性是什么类型,而不是是什么。所以加上了 typeof。
e.g. without typeof,I coding

Vue.component(Form.Item.name, Form.Item)

intellisense show Form.Item is a vue instance, not class,but expect is a class.

@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files         145      145           
  Lines        4744     4744           
  Branches     1404     1404           
=======================================
  Hits         4157     4157           
  Misses        543      543           
  Partials       44       44

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19effd0...6d6def5. Read the comment docs.

@tangjinzhou tangjinzhou requested review from wangxueliang and tangjinzhou and removed request for wangxueliang January 18, 2019 04:56
Copy link
Member

@tangjinzhou tangjinzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tangjinzhou tangjinzhou merged commit 0e78eed into vueComponent:master Jan 19, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants