Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add closable option for confirm dialog #798

Merged
merged 1 commit into from
May 23, 2019
Merged

feat: add closable option for confirm dialog #798

merged 1 commit into from
May 23, 2019

Conversation

yugasun
Copy link
Contributor

@yugasun yugasun commented May 23, 2019

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

For Modal component, when use it like Modal.method(), close icon will not display, but in practical, people may need a close icon for this dialog, so I made closable option for it, and default value is false.

API Realization (Optional if not new feature)

As the background say, we can show close icon like below:

Modal.info({
    title: 'This is a notification message',
    content: 'Hello Confirm Modal',
    closable: true,
})

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented May 23, 2019

Deploy preview for ant-desing-vue processing.

Building with commit 34f5a25

https://app.netlify.com/sites/ant-desing-vue/deploys/5ce669358394870007cdad56

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #798 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   87.26%   87.27%   +<.01%     
==========================================
  Files         145      145              
  Lines        4815     4816       +1     
  Branches     1419     1420       +1     
==========================================
+ Hits         4202     4203       +1     
  Misses        570      570              
  Partials       43       43
Impacted Files Coverage Δ
components/modal/ConfirmDialog.jsx 94.73% <100%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d478653...34f5a25. Read the comment docs.

@tangjinzhou tangjinzhou merged commit 00656b5 into vueComponent:master May 23, 2019
@yugasun yugasun deleted the feat/add-closable-option-for-confirm-dialog branch May 29, 2019 06:13
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants