Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apollo Client v3 migration #1031

Closed
wants to merge 5 commits into from
Closed

Apollo Client v3 migration #1031

wants to merge 5 commits into from

Conversation

mlesin
Copy link

@mlesin mlesin commented Aug 4, 2020

Can't wait for Apollo 3 support, decided to help you with that :)

During migration process, some dependencies were required to be bumped too, including @vue/composition-api 1.0.0-beta.6

Mikhail Lesin added 2 commits August 5, 2020 01:30
Docs are not fixed yet, e2e-composition test is failing at errorPolicy.js
@mlesin mlesin changed the title Apollo 3 migration Apollo Client v3 migration Aug 5, 2020
@the-jackalope
Copy link

I'm not part of the project so don't want to interject with a review, but @mlesin I think that instead of importing from @apollo/client we'd want to import from @apollo/client/core, no?

There's a section in the Apollo 3 docs that specifies importing from @apollo/client/core avoids importing React.

Either way thanks for doing this - excited for vue-apollo to support Apollo 3!

@mlesin
Copy link
Author

mlesin commented Aug 6, 2020

Thank you for noticing, @the-jackalope!
After I removed react dependency, it looks much cleaner now.

@the-jackalope the-jackalope mentioned this pull request Aug 12, 2020
@brunomperes
Copy link

Awesome work @mlesin !

Are there pending tasks for this that we can help with or is it good to review/merge? 😄

@mlesin
Copy link
Author

mlesin commented Aug 19, 2020

@brunomperes it is ready for review/merge.
The only thing left but I can't do is changes in chinese translation of docs because I don't understand chinese :)

@brunomperes
Copy link

I guess we also need to update the peer dependencies here ? https://github.com/vuejs/vue-apollo/blob/dev/packages/vue-apollo/package.json#L40-L42

@mlesin
Copy link
Author

mlesin commented Aug 21, 2020

@brunomperes this PR relates to v4 branch only. I can't find file you are pointing at in that branch

@dmitry
Copy link

dmitry commented Oct 8, 2020

@Akryum what is the status of this project, is it temporarily suspended or closed? Can we go forward and merge this PR? Any help required?

@Akryum
Copy link
Member

Akryum commented Oct 18, 2020

@mlesin Is there anything mssing from the current v4 branch that is added here? Could you rebase your branch please? 🙏 Thanks!

@mlesin
Copy link
Author

mlesin commented Oct 18, 2020

@Akryum I didn't introduced any functionality here except pure port to apollo-3.
At first sight, you're implemented the same thing yourself, plus some additional changes. So I don't think there is any need to rebase this PR.
I think it's safe to close it.

@Akryum Akryum closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants