-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apollo Client v3 migration #1031
Conversation
Docs are not fixed yet, e2e-composition test is failing at errorPolicy.js
I'm not part of the project so don't want to interject with a review, but @mlesin I think that instead of importing from There's a section in the Apollo 3 docs that specifies importing from Either way thanks for doing this - excited for |
Thank you for noticing, @the-jackalope! |
Awesome work @mlesin ! Are there pending tasks for this that we can help with or is it good to review/merge? 😄 |
@brunomperes it is ready for review/merge. |
I guess we also need to update the peer dependencies here ? https://github.com/vuejs/vue-apollo/blob/dev/packages/vue-apollo/package.json#L40-L42 |
@brunomperes this PR relates to v4 branch only. I can't find file you are pointing at in that branch |
@Akryum what is the status of this project, is it temporarily suspended or closed? Can we go forward and merge this PR? Any help required? |
@mlesin Is there anything mssing from the current v4 branch that is added here? Could you rebase your branch please? 🙏 Thanks! |
@Akryum I didn't introduced any functionality here except pure port to apollo-3. |
Can't wait for Apollo 3 support, decided to help you with that :)
During migration process, some dependencies were required to be bumped too, including @vue/composition-api 1.0.0-beta.6