Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Issue #924 (Cannot Re-assign $apollo) #930

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Fix for Issue #924 (Cannot Re-assign $apollo) #930

merged 2 commits into from
Jul 27, 2020

Commits on Feb 22, 2020

  1. Fix for Issue vuejs#924 (Cannot Re-assign $apollo) 

    vuejs#924

Added the recommended sanity check .hasOwnProperty that is best practice for .defineProperty to fix .$apollo redefinition bug when using more than one Vue application on a page, or multiple vue built standard web components, like a web component library.

This bug is a show stopper for using vue-apollo in standard web components but fortunately was easily fixable by adding the standard best practices check around the block to prevent redefinition.

Also worth noting that this same issue it has occurred and crept back into this project several times.
    @JoshuaJarman
    JoshuaJarman authored Feb 22, 2020
    Configuration menu
    Copy the full SHA
    16e9a21 View commit details
    Browse the repository at this point in the history

  2. Update: Adjusted indentation to pass project checks... 

    Update: Adjusted indentation to pass project checks...
    @JoshuaJarman
    JoshuaJarman authored Feb 22, 2020
    Configuration menu
    Copy the full SHA
    dc121e1 View commit details
    Browse the repository at this point in the history