fix(compiler-core): fix property shorthand detection

fix #845
vuejs · Mar 16, 2020 · 586e5bb · 586e5bb
1 parent c7ae269
commit 586e5bb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/compiler-core/__tests__/transforms/transformExpressions.spec.ts b/packages/compiler-core/__tests__/transforms/transformExpressions.spec.ts
@@ -317,6 +317,16 @@ describe('compiler: expression transform', () => {
     })
   })
 
+  test('should not duplicate object key with same name as value', () => {
+    const node = parseWithExpressionTransform(
+      `{{ { foo: foo } }}`
+    ) as InterpolationNode
+    expect(node.content).toMatchObject({
+      type: NodeTypes.COMPOUND_EXPRESSION,
+      children: [`{ foo: `, { content: `_ctx.foo` }, ` }`]
+    })
+  })
+
   test('should prefix a computed object property key', () => {
     const node = parseWithExpressionTransform(
       `{{ { [foo]: bar } }}`

diff --git a/packages/compiler-core/src/transforms/transformExpression.ts b/packages/compiler-core/src/transforms/transformExpression.ts
@@ -271,7 +271,8 @@ const isPropertyShorthand = (node: Node, parent: Node) => {
     isStaticProperty(parent) &&
     parent.value === node &&
     parent.key.type === 'Identifier' &&
-    parent.key.name === (node as Identifier).name
+    parent.key.name === (node as Identifier).name &&
+    parent.key.start === node.start
   )
 }