refactor: revert reactivity transform

vuejs · Mar 28, 2023 · 9a7bf74 · 9a7bf74
1 parent 2704d80
commit 9a7bf74
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 27 deletions.
diff --git a/packages/reactivity-transform/__tests__/__snapshots__/reactivityTransform.spec.ts.snap b/packages/reactivity-transform/__tests__/__snapshots__/reactivityTransform.spec.ts.snap
@@ -280,15 +280,6 @@ const props = defineProps<{msg: string; ids?: string[]}>()
         let ids = _ref([])"
 `;
 
-exports[`should support module string names syntax 1`] = `
-"
-    
-
-    let a = (ref(0));
-    console.log((a))
-    "
-`;
-
 exports[`using ref binding in property shorthand 1`] = `
 "import { ref as _ref } from 'vue'
 

diff --git a/packages/reactivity-transform/__tests__/reactivityTransform.spec.ts b/packages/reactivity-transform/__tests__/reactivityTransform.spec.ts
@@ -460,22 +460,6 @@ test('macro import alias and removal', () => {
   assertCode(code)
 })
 
-test('should support module string names syntax', () => {
-  const { code } = transform(
-    `
-    import { "$" as fromRefs, "$$" as escapeRefs } from 'vue/macros'
-
-    let a = fromRefs(ref(0));
-    console.log(escapeRefs(a))
-    `
-  )
-  // should remove imports
-  expect(code).not.toMatch(`from 'vue/macros'`)
-  expect(code).toMatch(`let a = (ref(0))`)
-  expect(code).toMatch(`console.log((a))`)
-  assertCode(code)
-})
-
 // #6838
 test('should not overwrite importing', () => {
   const { code } = transform(

diff --git a/packages/reactivity-transform/src/reactivityTransform.ts b/packages/reactivity-transform/src/reactivityTransform.ts
@@ -18,7 +18,6 @@ import MagicString, { SourceMap } from 'magic-string'
 import { walk } from 'estree-walker'
 import {
   extractIdentifiers,
-  getImportedName,
   isFunctionType,
   isInDestructureAssignment,
   isReferencedIdentifier,
@@ -199,7 +198,11 @@ export function transformAST(
 
     for (const specifier of node.specifiers) {
       const local = specifier.local.name
-      const imported = getImportedName(specifier)
+      const imported =
+        (specifier.type === 'ImportSpecifier' &&
+          specifier.imported.type === 'Identifier' &&
+          specifier.imported.name) ||
+        'default'
       userImports[local] = {
         source,
         local,