Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vue/compat: Bootstrap-Vue modals not properly displayed since Vue 3.4.9 #10151

Closed
kernoeb opened this issue Jan 18, 2024 · 2 comments · Fixed by #10161 or #10297
Closed

@vue/compat: Bootstrap-Vue modals not properly displayed since Vue 3.4.9 #10151

kernoeb opened this issue Jan 18, 2024 · 2 comments · Fixed by #10161 or #10297

Comments

@kernoeb
Copy link

kernoeb commented Jan 18, 2024

Vue version

3.4.9

Link to minimal reproduction

https://stackblitz.com/edit/bootstrap-vue-with-compat-nszxaj?file=package.json

Steps to reproduce

Install bootstrap-vue 2 with @vue/compat and a recent Vue.js 3 version.

this.$bvModal.msgBoxOk('Modal from @vue/compat');

(Clicking the button in the Stackblitz example should display a modal)

What is expected?

In Vue 3.4.8, when clicking button, the popup is displayed with a style display: block.
Since Vue 3.4.9, the style is missing and the bootstrap modal is not properly displayed.

What is actually happening?

The display: block style is missing in the div displaying the modal.

I think this may be related to v3.4.8...v3.4.9#diff-f9113ab49228dff481a60e308d4d5f6a62007da817950de5fbbf8f1dd31e85f4R154

System Info

System:
  OS: Linux 5.0
  CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
  Memory: 0 Bytes / 0 Bytes
  Shell: 1.0 - /bin/jsh
Binaries:
  Node: 18.18.0 - /usr/local/bin/node
  Yarn: 1.22.19 - /usr/local/bin/yarn
  npm: 10.2.3 - /usr/local/bin/npm
  pnpm: 8.14.0 - /usr/local/bin/pnpm

Any additional comments?

No response

@yyx990803
Copy link
Member

Likely caused by #10075

@Doctor-wu
Copy link
Member

Doctor-wu commented Jan 19, 2024

According to the doc. In this case, I think the correct behavior is when isVisible is false, modal content should not show no matter the display value is, and when isVisible is true, should switch style when click on Change Style button.

Doctor-wu added a commit to Doctor-wu/core that referenced this issue Jan 19, 2024
yyx990803 added a commit that referenced this issue Feb 9, 2024
@yyx990803 yyx990803 reopened this Feb 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants