fix: the value of display is sometimes incorrect with v-show #10297
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a optimize about #10161,close #10151 and won't lead to the issue in #10294
For an element with
v-show
, when itsstyle
changes,el[vShowOldKey]
is assigned asstyle.display
, regardless of whether display exists in the style. Ifv-show === false
and there is nodisplay
instyle
, the value ofstyle.display
is'none'
at this time, soel[vShowOldKey]
will also be incorrectly assigned as 'none'.The correct logic should be:
el[vShowOldKey] = style.display
only when display exists in the next style; otherwise,el[vShowOldKey] = ''
.