-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended array methods are called with unexpected values #11570
Labels
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
scope: reactivity
version: minor
Comments
scottbedard
changed the title
Extended array classes cannot overwrite parent methods
Extended array methods are called with unexpected values
Aug 8, 2024
jh-leong
added
scope: reactivity
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
labels
Aug 8, 2024
edison1105
added
version: minor
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
and removed
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
labels
Aug 9, 2024
edison1105
added a commit
to edison1105/vuejs-core
that referenced
this issue
Aug 9, 2024
yyx990803
pushed a commit
that referenced
this issue
Aug 9, 2024
closed via #11572 |
Thank you both, I appreciate all the hard work! |
yyx990803
pushed a commit
to edison1105/vuejs-core
that referenced
this issue
Aug 10, 2024
yyx990803
pushed a commit
that referenced
this issue
Aug 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
❗ p4-important
Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf.
scope: reactivity
version: minor
Vue version
3.5.0-beta.1
Link to minimal reproduction
3.4.37 → 3.5.0-beta.1
Steps to reproduce
Array
super
to augment an array methodWhat is expected?
The extended method should be called with the provided parameter, and be able to forward that parameter to the parent method.
What is actually happening?
The extended method receives a function, regardless of what is provided by the caller.
System Info
Any additional comments?
I suspect this is related to the optimized array tracking, but have not isolated the exact cause yet.
#9511
Update: It looks like the issue lies here, our reactivity logic depends on these signatures matching the native array.
The text was updated successfully, but these errors were encountered: