Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox 52, 53 click event invoker doesn't work #3485

Closed
trailskr opened this issue Mar 25, 2021 · 0 comments · Fixed by #3501
Closed

Firefox 52, 53 click event invoker doesn't work #3485

trailskr opened this issue Mar 25, 2021 · 0 comments · Fixed by #3501
Labels
browser specific ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working

Comments

@trailskr
Copy link

Version

3.0.7

Reproduction link

https://jsfiddle.net/iagafonov/ja5zx6cm/

Steps to reproduce

Use Firefox 52, click red element

What is expected?

click works (element text changed to "clicked")

What is actually happening?

click doesn't work

https://github.com/vuejs/vue-next/blob/bd1240c1270b610c4ffcf6c32e2bbe2c9265020f/packages/runtime-dom/src/modules/events.ts#L113
In Firefox < 52 and 53, e.timestamp - in wrong and strange format (for example todays e.timestamp === 237142265). That's why checking if (timeStamp >= invoker.attached - 1) { never passes
@posva posva added 🐞 bug Something isn't working ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Mar 25, 2021
@HcySunYang HcySunYang mentioned this issue Mar 29, 2021
Merged
yyx990803 pushed a commit that referenced this issue Mar 29, 2021
@HcySunYang
fix(runtime-dom): fix event listeners call in firefox <= 53 (#3501)
33ba0e3 
fix #3485
@mivui mivui mentioned this issue Oct 16, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
browser specific ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. 🐞 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-dom): fix the event listeners call in firefox <= 53
3 participants
@posva @LinusBorg @trailskr