Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(compiler-core): add test for identifier collision #7078

Closed
wants to merge 1 commit into from

Conversation

znck
Copy link
Member

@znck znck commented Nov 10, 2022

We do not use local alias when we rewrite export { foo as default } ... to import { foo } ..., this could result in identifier collision.

Depends on #7608 as it changes rewrite logic.

@sxzz maybe you can pull this in your PR.

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 28c8795
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/636c71809ab93800080fbae2

@sxzz
Copy link
Member

sxzz commented Nov 10, 2022

@znck Added to #7608, thanks!

@znck znck closed this Nov 10, 2022
yyx990803 pushed a commit that referenced this pull request Mar 28, 2023
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants