fix(compiler-sfc): analyze export default by AST #7068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znck
suggested changes
Nov 9, 2022
❌ Deploy Preview for vuejs-coverage failed.
|
znck
approved these changes
Nov 9, 2022
znck
suggested changes
Nov 10, 2022
|
@znck Done. |
znck
approved these changes
Nov 11, 2022
znck
added
🔨 p3-minor-bug
sxzz
added
ready to merge
sxzz
commented
Nov 11, 2022
yyx990803
requested changes
Nov 12, 2022
There was a problem hiding this comment.
A problem with this approach: rewriteDefault is used in @vitejs/plugin-vue here, on the script string already transformed by compileScript. This means the string no longer matches the Node positions in the AST exposed on the SFC descriptor.
I think we need to do something similar to reactivity transform's transformAST:
- Accept both the AST and the corresponding MagicString instance in
rewriteDefault - Also expose the MagicString instance on the script block returned by
compileScript - In
@vitejs/plugin-vue, feature detect by checking whether MagicString instance is available
- If yes, use AST-based rewrite by passing in AST + MagicString
- If no, fallback to old usage
9 tasks
|
@sxzz did you end up re-creating vitejs/vite#10888 for https://github.com/vitejs/vite-plugin-vue? |
|
@yyx990803 No, I haven't done it yet. |
9 tasks
IAmSSH
pushed a commit
to IAmSSH/core
that referenced
this pull request
May 14, 2023
…f regex (vuejs#7068) closes vuejs#7038 closes vuejs#7041 closes vuejs#7078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7038, closes #7041, closes #7078
vite plugin PR vitejs/vite#10888
thanks to @btea