Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please export enum ErrorCodes inside runtime-core #833

Closed
zxc122333 opened this issue Mar 14, 2020 · 0 comments · Fixed by #840
Closed

Please export enum ErrorCodes inside runtime-core #833

zxc122333 opened this issue Mar 14, 2020 · 0 comments · Fixed by #840

Comments

@zxc122333
Copy link

What problem does this feature solve?

The function callWithAsyncErrorHandling at runtime-core/src/errorHandling.ts is exported, but the third argument type: ErrorTypes is not.

Please export it, so that third-party runtime could handle events like runtime-dom.

What does the proposed API look like?

N/A
underfin added a commit to underfin/vue-next that referenced this issue Mar 15, 2020
@underfin
feat(runtime-core): export ErrorTypes to can be used with callWithE…
c72f793 
…rrorHandling

fix vuejs#833
@underfin underfin mentioned this issue Mar 15, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(runtime-core): export ErrorTypes to can be used with callWithE… underfin/vue-next
1 participant
@zxc122333