Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename globalsWhitelist.ts isGloballyWhitelisted to use more inclusive language #8416

Closed
rniwa opened this issue May 26, 2023 · 2 comments · Fixed by encourage317125/core#30
Closed

Rename globalsWhitelist.ts isGloballyWhitelisted to use more inclusive language #8416

rniwa opened this issue May 26, 2023 · 2 comments · Fixed by encourage317125/core#30

Comments

@rniwa
Copy link

rniwa commented May 26, 2023

Vue version

3.2.47

Link to minimal reproduction

https://github.com/vuejs/core/blob/020851e57d9a9f727c6ea07e9c1575430af02b73/packages/shared/src/globalsWhitelist.ts

Steps to reproduce

Open https://github.com/vuejs/core/blob/020851e57d9a9f727c6ea07e9c1575430af02b73/packages/shared/src/globalsWhitelist.ts

What is expected?

More inclusive language such as "allowed" is used.

What is actually happening?

Non-inclusive language "whitelisted" is used.

System Info

No response

Any additional comments?

No response
@rniwa rniwa mentioned this issue May 26, 2023
Closed
@rniwa
Copy link
Author

rniwa commented May 26, 2023

Thank you!

@encourage317125 encourage317125 mentioned this issue May 29, 2023
Merged
@haoqunjiang
Copy link
Member

haoqunjiang commented May 29, 2023 •
edited
Loading

Unfortunately, this is a public export. Therefore renaming it is a breaking change.

It's already causing ecosystem-ci failures: https://github.com/vuejs/ecosystem-ci/actions/runs/5108624282
IMO, the best we can do in the current major version is to deprecate it.

@haoqunjiang haoqunjiang mentioned this issue Jun 12, 2023
Merged
haoqunjiang added a commit to haoqunjiang/core that referenced this issue Jun 12, 2023
@haoqunjiang
fix: add isGloballyWhitelisted back, but deprecated
dd1ac44 
Fixes the regression described at vuejs#8416 (comment)
yyx990803 pushed a commit that referenced this issue Jun 14, 2023
@haoqunjiang
fix: add isGloballyWhitelisted back, but deprecated (#8556)
63dfe8e 
Fixes the regression described at #8416 (comment)
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename globals allow list vuejs/core
2 participants
@rniwa @haoqunjiang