Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested components in detached branch render while being detached even with child suspensible suspense #8678

Closed
zkulbeda opened this issue Jun 29, 2023 · 1 comment · Fixed by #10055
Closed

Nested components in detached branch render while being detached even with child suspensible suspense #8678

zkulbeda opened this issue Jun 29, 2023 · 1 comment · Fixed by #10055
Labels
scope: suspense

Comments

@zkulbeda
Copy link

zkulbeda commented Jun 29, 2023 •
edited
Loading

Vue version

3.3.4

Link to minimal reproduction

https://play.vuejs.org

Steps to reproduce

  • Click on Show Async
  • Wait for everything to be displayed

What is expected?

  • The async child should render only once in the first click

What is actually happening?

  • The toggle causes the async child to render twice

System Info

No response

Any additional comments?

Previous bug #5513 was closed due to the introduction of the suspensible option. But the bug is still present even when using suspensible on Suspense. This issue is blocking vuejs/router#1324 from closing
@719media
Copy link

719media commented Jan 9, 2024

Just noting for reference, verified this is still a problem with vue v3.4.6

@edison1105 edison1105 mentioned this issue Jan 9, 2024
Merged
yyx990803 pushed a commit that referenced this issue Jan 11, 2024
@edison1105
fix(suspense): avoid double-patching nested suspense when parent susp…
bcda96b 
…ense is not resolved (#10055)

close #8678
edison1105 added a commit to edison1105/vuejs-core that referenced this issue Jan 11, 2024
@edison1105
fix(suspense): avoid double-patching nested suspense when parent susp…
39cca06 
…ense is not resolved (vuejs#10055)

close vuejs#8678
@nathanchase nathanchase mentioned this issue Jan 19, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope: suspense
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Suspense): skip patch nested suspense if parent suspense is not resolved edison1105/vuejs-core
3 participants
@edison1105 @719media @zkulbeda