fix(compiler-sfc): fix missing ReadonlyArray, ReadonlySet, ReadonlyMap and UnknownType (fix #10726) #10746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the type of ReadonlyArray should be object, I'm not quite sure. |
NathanFreeman
force-pushed
the
ReadonlyArray_type
branch
from
b7ac88c to
6808b11
Compare
NathanFreeman
changed the title
…p and UnknownType
NathanFreeman
force-pushed
the
ReadonlyArray_type
branch
from
eaf91a2 to
1566f37
Compare
NathanFreeman
changed the title
yyx990803
reviewed
Apr 22, 2024
|
|
||
| export default /*#__PURE__*/_defineComponent({ | ||
| props: { | ||
| "modelValue": { type: [String, ReadonlyArray, ReadonlySet, ReadonlyMap], skipCheck: true }, |
There was a problem hiding this comment.
This doesn't make sense. ReadonlyArray is a TS type, not a built-in JavaScript object at runtime.
There was a problem hiding this comment.
Thank you!
Okay, can I move the ReadonlyArray, ReadonlySet, ReadonlyMap to the next case and return it as an object?
Size ReportBundles
Usages
|
|
Thanks for the PR, however I don't think these are the right fixes. The tests are also not See 5cef52a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.