fix(watch): deep watching symbol properties #10969
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, deep watchers don't traverse symbol properties.
#402 already attempts a fix for this, but that seems to have stalled due to some performance tweaks that were made at the same time. Here I've just tried to fix the core problem with symbols.
String properties are traversed using
for
/in
. That traverses enumerable properties, including those inherited from the prototype. I didn't want to do anything that might break that, so I've left it untouched.For symbols I've used
getOwnPropertySymbols
andpropertyIsEnumerable
. This doesn't take the prototype chain into account.Is traversing symbol properties actually useful? I don't know. If not, perhaps it should be documented that they aren't supported? Currently it's a bit inconsistent, as adding or removing a symbol property will trigger the watcher, but updating the value or mutating a nested value won't.
I've marked this as a
fix
, though it could be viewed as afeat
.