Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core/v-on): support inline handlers w/ type annotations in parameters #11616

Closed
wants to merge 2 commits into from

Conversation

jh-leong
Copy link
Member

close #11615

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.7 kB 37.4 kB 33.7 kB
vue.global.prod.js 156 kB (+14 B) 57.2 kB (+9 B) 50.8 kB (+29 B)

Usages

Name Size Gzip Brotli
createApp 54.1 kB 21 kB 19.1 kB
createSSRApp 58.1 kB 22.6 kB 20.6 kB
defineCustomElement 58.8 kB 22.5 kB 20.5 kB
overall 67.7 kB 26 kB 23.7 kB

@jh-leong jh-leong added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Aug 14, 2024
@yyx990803
Copy link
Member

The regex-based fix is unsound, so I decided to go with AST-based check in non-browser builds. When compiling in browser, there won't be TS syntax anyway.

See 5861229

@yyx990803 yyx990803 closed this Aug 15, 2024
@jh-leong jh-leong deleted the fix/11615 branch August 15, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Union typed array events do not trigger event handlers
3 participants