Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(customElement): support set key on ceVNode #11655

Merged
merged 12 commits into from
Aug 29, 2024
Merged

Conversation

edison1105
Copy link
Member

close #11641

@edison1105 edison1105 marked this pull request as draft August 19, 2024 04:01
Copy link

github-actions bot commented Aug 19, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+51 B) 37.7 kB (+14 B) 33.9 kB (+40 B)
vue.global.prod.js 159 kB (+51 B) 57.5 kB (+16 B) 51.1 kB (-54 B)

Usages

Name Size Gzip Brotli
createApp 55.1 kB 21.2 kB 19.3 kB
createSSRApp 59.1 kB 22.9 kB 20.9 kB
defineCustomElement 59.8 kB (+51 B) 22.7 kB (+17 B) 20.7 kB (+14 B)
overall 68.8 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Aug 19, 2024

commit: 5bbadb6

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11655

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11655

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11655

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11655

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11655

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11655

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11655

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11655

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11655

vue

pnpm add https://pkg.pr.new/vue@11655

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11655

Open in Stackblitz

@edison1105 edison1105 marked this pull request as ready for review August 22, 2024 10:19
@edison1105 edison1105 added 🐞 bug Something isn't working scope: ssr scope: custom elements ready for review This PR requires more reviews labels Aug 22, 2024
@edison1105 edison1105 marked this pull request as draft August 22, 2024 12:09
@edison1105 edison1105 marked this pull request as ready for review August 22, 2024 12:38
@yyx990803 yyx990803 merged commit f1d1831 into vuejs:main Aug 29, 2024
13 checks passed
@edison1105 edison1105 deleted the fix/11641 branch August 30, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ready for review This PR requires more reviews scope: custom elements scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hydrating vue custom element with key prop will cause unexpected re-mount and lose parent context
2 participants