Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Hydration): implement proper check for __asyncHydrate #11825

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

Tofandel
Copy link
Contributor

@Tofandel Tofandel commented Sep 5, 2024

Fixes #11793

Simply add a proper check on the existance of __asyncHydrate so that vue 3.5 and vue3-lazy-hydration can coexist until we get vue3-lazy-hydration up to date with the new hydration api

Copy link

github-actions bot commented Sep 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+18 B) 37.7 kB (+3 B) 34 kB (-40 B)
vue.global.prod.js 159 kB (+18 B) 57.6 kB (+3 B) 51.3 kB (-25 B)

Usages

Name Size Gzip Brotli
createApp 55.3 kB (+18 B) 21.3 kB (+4 B) 19.4 kB (-44 B)
createSSRApp 59.3 kB (+18 B) 23 kB (+2 B) 20.9 kB (-57 B)
defineCustomElement 60 kB (+18 B) 22.8 kB (+5 B) 20.7 kB (-51 B)
overall 69.1 kB (+18 B) 26.3 kB (+2 B) 24 kB (+23 B)

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11825

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11825

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11825

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11825

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11825

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11825

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11825

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11825

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11825

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11825

vue

pnpm add https://pkg.pr.new/vue@11825

commit: 8b91ef8

@edison1105
Copy link
Member

I’m not sure if this fix is necessary, but you make a good point.
It seems that vue3-lazy-hydration hasn’t been adapted for 3.5

@edison1105 edison1105 added the need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. label Sep 5, 2024
@yyx990803
Copy link
Member

#11793 (comment)

@yyx990803 yyx990803 closed this Sep 5, 2024
@yyx990803 yyx990803 reopened this Sep 6, 2024
@Justineo Justineo closed this Sep 6, 2024
@Justineo Justineo reopened this Sep 6, 2024
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: ssr and removed need guidance The approach/solution in the PR is unclear and requires guidance from maintainer to proceed further. labels Sep 6, 2024
@yyx990803 yyx990803 merged commit 8e6c337 into vuejs:main Sep 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: ssr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.5.0 __asyncHydrate is not a function
4 participants