Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): do not skip TSInstantiationExpression when transforming props destructure #12064

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

linzhe141
Copy link
Contributor

@linzhe141 linzhe141 commented Sep 28, 2024

Copy link

github-actions bot commented Sep 28, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.1 kB 34.3 kB
vue.global.prod.js 160 kB 58 kB 51.5 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49 kB 18.9 kB 17.2 kB
createApp 55.6 kB 21.4 kB 19.6 kB
createSSRApp 59.6 kB 23.1 kB 21 kB
defineCustomElement 60.4 kB 23 kB 20.9 kB
overall 69.3 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Sep 28, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12064

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12064

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12064

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12064

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12064

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12064

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12064

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12064

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12064

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12064

vue

pnpm add https://pkg.pr.new/vue@12064

commit: a521ee8

@linzhe141 linzhe141 closed this Sep 28, 2024
@linzhe141 linzhe141 reopened this Sep 28, 2024
@linzhe141 linzhe141 changed the title fix(compiler-sfc): not skip TSInstantiationExpression fix(compiler-sfc): do not skip TSInstantiationExpressionwhen transforming props destructure Sep 28, 2024
@linzhe141 linzhe141 changed the title fix(compiler-sfc): do not skip TSInstantiationExpressionwhen transforming props destructure fix(compiler-sfc): do not skip TSInstantiationExpression when transforming props destructure Sep 28, 2024
@edison1105 edison1105 added scope: sfc 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Sep 29, 2024
@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Sep 29, 2024
@yyx990803 yyx990803 merged commit d3ecde8 into vuejs:main Oct 11, 2024
13 checks passed
@linzhe141 linzhe141 deleted the define-props-destructure branch October 11, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants