test(TransitionGroup): test for TransitionGroup
#1269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfin
commented
May 31, 2020
| transitionNumber-- | ||
| if (transitionNumber === 0) { | ||
| ;[enterFromClass, enterActiveClass, enterToClass] = originEnterClass | ||
| } |
There was a problem hiding this comment.
For TransitionGroup has more than one child nodes. Need reset class when last node transition end.
This solution can be work.Maybe has more better solution, but I just has this one.
underfin
commented
May 31, 2020
| <!-- return { toggle, click }--> | ||
| <!-- }--> | ||
| <!-- }).mount('#app')--> | ||
| <!--</script>--> |
There was a problem hiding this comment.
This has confict with #1151
| instance.vnode.el as Node, | ||
| moveClass | ||
| ) | ||
| ) { |
There was a problem hiding this comment.
This need check when every update triggle.Because maybe has dynamic name which has css transform.
Well. we can reset value of hasMove when re-invoke render with returned by setup.But this can be more directly and clearly.
yyx990803
force-pushed
the
transition-group
branch
2 times, most recently
from
c78a193 to
9a2456f
Compare
yyx990803
force-pushed
the
transition-group
branch
from
28c8fb7 to
58f4533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.