fix(reactivity): Array.prototype.push causes infinite recursion

[unbyte]

Calling Array.prototype.push, which gets .length and sets values at the same time, may lead to an infinite recursion

for example

  const a = reactive([])

  watchEffect(() => {
      a.push(1)
  })

  watchEffect(() => {
      a.push(1)
  })

[yyx990803]

This is fixed by 3810de7

[unbyte]

@yyx990803 This fix has nothing to do with 3810de7

[unbyte]

I've pull the latest code and run the test, and it failed

  it('should avoid infinite recursive loops when use Array.prototype.push', () => {
    const arr = reactive<number[]>([])

    const counterSpy1 = jest.fn(() => arr.push(1))
    const counterSpy2 = jest.fn(() => arr.push(2))
    effect(counterSpy1)
    effect(counterSpy2)
    expect(arr.length).toBe(2)
    expect(counterSpy1).toHaveBeenCalledTimes(1)
    arr.push(3)
    expect(arr.length).toBe(3)
    expect(counterSpy1).toHaveBeenCalledTimes(1)
  })

This recursion is not due to the self-calls of the effect, but that push changes length while it depends on length.

[dsonet]

@unbyte If so, unshift may should also be included.

[unbyte]

@dsonet and pop and shift, they all cause infinite recursion cuz they all depend on .length